[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: glibc-hurd: Force mach/hurd/libpthread subdirs to build
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH] gnu: glibc-hurd: Force mach/hurd/libpthread subdirs to build first. |
Date: |
Mon, 14 Nov 2016 14:05:05 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
address@hidden skribis:
> From: Manolis Ragkousis <address@hidden>
>
> * gnu/packages/base.scm (glibc/hurd): Avoid linking errors by forcing
> mach/hurd/libpthread glibc subdirs to build before anything else.
Rather:
* gnu/packages/base.scm (glibc/hurd)[arguments]: Replace 'build' phase.
The comment in there is what explains the details.
> + (alist-replace
> + 'build
> + (lambda _
> + ;; Force mach/hurd/libpthread subdirs to build first in order
> to avoid
> + ;; linking errors.
If there’s a link to a bug-hurd discussion, you can add it here, in case
someone wants to see the details at a later point in time.
> + (zero?
> + (and (system* "make" "mach/subdir_lib")
> + (system* "make" "hurd/subdir_lib")
> + (system* "make" "libpthread/subdir_lib")
> + (system* "make"))))
The ‘zero?’ call is misplaced.
Also, I’d suggest enabling parallel builds, so something like this:
(let ((-j (list "-j" (number->string (parallel-job-count)))))
(let-syntax ((make (syntax-rules ()
((_ target)
(zero? (apply system* "make" target -j))))))
(and (make "mach/subdir_lib")
(make "hurd/subdir_lib")
(make "libpthread/subdir_lib")
(zero? (apply system* "make" -j)))))
OK with changes along these lines.
Thank you!
Ludo’.