Re: [PATCH] gnu: Remove redundancy where mkdir-p <dir> is followed by install-file <file> <dir>.

[Ludovic Courtès]

Hi Petter,

Sounds like a good idea.

Petter <address@hidden> skribis:

> From 595d438789c7c9a293ae7fac500ace7422073624 Mon Sep 17 00:00:00 2001
> From: Petter <address@hidden>
> Date: Sun, 20 Nov 2016 13:39:13 +0100
> Subject: [PATCH] gnu: Remove redundancy where mkdir-p <dir> is followed by
>  install-file <file> <dir>.
>
> * gnu/packages/bioinformatics.scm (bwa)[source]: Remove redundant mkdir-p.
> * gnu/packages/bioinformatics.scm (eigensoft)[source]: Likewise.
> * gnu/packages/bioinformatics.scm (snap-aligner)[source]: Likewise.
> * gnu/packages/bioinformatics.scm (pardre)[source]: Likewise.
> * gnu/packages/bioinformatics.scm (piranha)[source]: Likewise.

Nitpick: no need to repeat the file name for each entry here.

> * gnu/packages/maths.scm (hypre)[source]: Likewise.
> * gnu/packages/mp3.scm (mpc123)[source]: Likewise.
> * gnu/packages/music.scm (tuxguitar)[source]: Likewise.
> * gnu/packages/pdf.scm (impressive)[source]: Likewise.
> * gnu/packages/qemu.scm (qemu)[source]: Likewise.
> * gnu/packages/tls.scm (openssl)[source]: Likewise.

The only question here before we can apply is how much gets rebuilt as a
consequence of this change.

Changing openssl would rebuild too much for instance, so that would go
to the ‘core-updates’ branch.

The rest looks OK for master, but could you check with ‘guix refresh -l’
and submit separate patches accordingly?  See
<https://lists.gnu.org/archive/html/guix-devel/2016-10/msg00933.html>
on how to choose a branch.

Thank you!

Ludo’.