[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gc: Add option --keep-going.
From: |
Hartmut Goebel |
Subject: |
Re: [PATCH] gc: Add option --keep-going. |
Date: |
Thu, 24 Nov 2016 10:28:32 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
Hi Eric,
thanks for the review and finding all these typos :-)
Am 18.11.2016 um 05:49 schrieb Eric Bavier:
>> > + printMsg(lvlError, format("cannot delete path `%1%' since
>> > it is still alive") % *i);
> ^
> Is error formatting appropriate, or is there a warning level we can use?
>
I agree that these are warnings and no errors. There is not "lvlWarn",
thoug, just "lvlInfo". So I took this value from a few lines below which
say:
if (state.shouldDelete)
printMsg(lvlError, format("deleting garbage..."));
else
printMsg(lvlError, format("determining live/dead paths..."));
So, what do you think?
--
Regards
Hartmut Goebel
| Hartmut Goebel | address@hidden |
| www.crazy-compilers.com | compilers which you thought are impossible |