guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] gnu: psyclpc: Make it reproducible.


From: Marius Bakke
Subject: Re: [PATCH 1/2] gnu: psyclpc: Make it reproducible.
Date: Sat, 26 Nov 2016 10:02:10 +0100
User-agent: Notmuch/0.23.2 (https://notmuchmail.org) Emacs/25.1.1 (x86_64-unknown-linux-gnu)

Leo Famulari <address@hidden> writes:

> On Wed, Nov 23, 2016 at 07:04:36PM +0000, ng0 wrote:
>> * gnu/packages/psyc.scm (psyclpc): Make it reproducible.
>> ---
>>  gnu/packages/psyc.scm | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>> 
>> diff --git a/gnu/packages/psyc.scm b/gnu/packages/psyc.scm
>> index 03df188..01bbae6 100644
>> --- a/gnu/packages/psyc.scm
>> +++ b/gnu/packages/psyc.scm
>> @@ -1,5 +1,5 @@
>>  ;;; GNU Guix --- Functional package management for GNU
>> -;;; Copyright © 2016 ng0 <address@hidden>
>> +;;; Copyright © 2016 ng0 <address@hidden>
>>  ;;;
>>  ;;; This file is part of GNU Guix.
>>  ;;;
>> @@ -155,7 +155,7 @@ including psyced.")
>>  
>>  ;; This commit removes the historic bundled pcre, not released as a tarball 
>> so far.
>>  (define-public psyclpc
>> -  (let* ((commit "8bd51f2a4847860ba8b82dc79348ab37d516011e")
>> +  (let* ((commit "61cf9aa81297085e5c40170fd01221c752f8deba")
>>           (revision "1"))
>
> Is it a newer commit? I think the revision counter should increase to 2.
> Or else `guix pcakage -u` won't update users' psyclpc installations.

Doesn't it? I was under the impression that `guix package -u` detected
when the derivation has changed, and updates to the current version
regardless of version number.

I do agree that incrementing the revision is good regardless, since
users will know that the code has changed, and not just some dependency.

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]