[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 9/9] gnu: Add ocaml-menhir.
|
From: |
Leo Famulari |
|
Subject: |
Re: [PATCH 9/9] gnu: Add ocaml-menhir. |
|
Date: |
Sat, 3 Dec 2016 15:12:30 -0500 |
|
User-agent: |
Mutt/1.7.1 (2016-10-04) |
On Sat, Dec 03, 2016 at 11:42:13AM +0100, David Craven wrote:
> * gnu/packages/ocaml.scm (ocaml-menhir): New variable.
> + #:phases
> + (modify-phases %standard-phases
> + (replace 'configure
> + (lambda* (#:key outputs #:allow-other-keys)
> + (let ((out (assoc-ref outputs "out")))
> + (setenv "PREFIX" out))
> + #t)))))
This is skipping the configure phase and reusing it to set the PREFIX
variable, right?
If so, I think it's better to delete the configure phase and set the
variable in its own set-env phase, or with #:configure-flags or
#:make-flags (if they are respected by this build system).