guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/3] gnu: python2-notebook: Fix build.


From: Leo Famulari
Subject: Re: [PATCH 3/3] gnu: python2-notebook: Fix build.
Date: Mon, 5 Dec 2016 16:44:34 -0500
User-agent: Mutt/1.7.1 (2016-10-04)

On Mon, Dec 05, 2016 at 01:21:05PM +0100, Hartmut Goebel wrote:
> * gnu/packages/python.scm (python2-notebook)[properties]: Add
> python2-variant.
> (python2-notebook)[native-packages] add python2-mock. [arguments] Add
> phase "disable-test-case" for disabling a failing test. immediately

s/ immediately//

>  (define-public python2-notebook
> -  (package-with-python2 python-notebook))
> +  (let ((base (package-with-python2
> +                (strip-python2-variant python-notebook))))
> +    (package (inherit base)
> +      (native-inputs
> +       `(("python2-mock" ,python2-mock)
> +         ,@(package-native-inputs base)))
> +      (arguments
> +       (substitute-keyword-arguments (package-arguments base)
> +         ((#:phases phases)
> +          `(modify-phases ,phases
> +             (add-before 'check 'disable-test-case
> +              ;; The test requires network access to localhost. Curiously it
> +              ;; files with Python 2 only. Simply make the test-case return

s/files/fails

Otherwise LGTM, thanks! I was just noticing this issue :)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]