guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Pytest update to 2.9.2


From: Leo Famulari
Subject: Re: Pytest update to 2.9.2
Date: Thu, 8 Dec 2016 19:28:30 -0500
User-agent: Mutt/1.7.1 (2016-10-04)

On Tue, Dec 06, 2016 at 11:41:24AM +0100, Hartmut Goebel wrote:
> Am 05.12.2016 um 22:33 schrieb Leo Famulari:
> > +             (substitute* "testing/test_argcomplete.py"
> > +               (("def test_remove_dir_prefix" line)
> > +                (string-append "@pytest.mark.skip"
> > +                               "(reason=\"Assumes that /usr exists.\")\n   
> >  "
> > +                               line)))
> 
> These trailing spaces in the replacement string are a bit irritating.
> Perhaps its better to search for "^\s+def …" and replace with "   
> @pytest.skip…" (leading spaces here). I don't know.
> 
> Otherwise LGTM.

Should we try this with your Sphinx update patches on a python-updates
branch? After staging is merged?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]