Re: [PATCH 09/96] gnu: Add camlzip

[Julien Lepiller]

On Sun, 8 Jan 2017 22:16:05 +1000
Ben Woodcroft <address@hidden> wrote:

> Hi Julien,
> 
> Thanks for all your efforts in this patch series - impressive stuff,
> and thanks to David for reviewing them.
> 
> On 04/01/17 05:10, Julien Lepiller wrote:
> [...]
> > +    (arguments `(#:phases
> > +                 (modify-phases %standard-phases
> > +                   (delete 'configure)
> > +                   (add-before 'install 'fix-install-name
> > +                     (lambda* (#:key #:allow-other-keys)
> > +                       (substitute* "Makefile"
> > +                         (("install zip") "install camlzip")))))  
> Can I ask if this substitution is necessary? I have a downstream
> OCaml package (pplacer) which is failing to compile because of it
> (though with OCaml 4.01.0).
> 
> I've attached my unpolished, convoluted patch series to get to
> pplacer, for reference.
> 
> Thanks, ben.

It was required because the dependant packages I had looked for camlzip
instead of just zip. Looking at the opam recipe though, it seems some
packages also refer to this one as zip. Could you try with that patch?
I also fixed the install directory.

0001-gnu-camlzip-Install-both-zip-and-camlzip-modules.patch
Description: Text Data