Re: [PATCH] gnu: Add emacs-sx.

[Alex Kost]

ng0 (2017-01-15 21:10 +0000) wrote:

> From: ng0 <address@hidden>
>
> * gnu/packages/emacs.scm (emacs-sx): New variable.

Thanks, I committed it as 899bcad310.  See the comments below.

> ---
>  gnu/packages/emacs.scm | 26 +++++++++++++++++++++++++-
>  1 file changed, 25 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index 50cea7685..ca038bcb2 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -12,7 +12,7 @@
>  ;;; Copyright © 2016 David Thompson <address@hidden>
>  ;;; Copyright © 2016 Matthew Jordan <address@hidden>
>  ;;; Copyright © 2016 Roel Janssen <address@hidden>
> -;;; Copyright © 2016 ng0 <address@hidden>
> +;;; Copyright © 2016, 2017 ng0 <address@hidden>

So are you going to use this email now?  ".mailmap" still prefers
<address@hidden>.

>  ;;; Copyright © 2016 Alex Griffin <address@hidden>
>  ;;; Copyright © 2016 Nicolas Goaziou <address@hidden>
>  ;;; Copyright © 2016 Alex Vong <address@hidden>
> @@ -1391,6 +1391,30 @@ allows easily move between them.")
>  strings.")
>      (license license:gpl3+)))
>  
> +(define-public emacs-sx
> +  (package
> +    (name "emacs-sx")
> +    (version "0.4")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://github.com/vermiculus/sx.el/";
> +                           "archive/v" version ".tar.gz"))
> +       (file-name (string-append name "-" version ".tar"))
                                                     ^^^^^
I changed it to ".tar.gz"

> +       (sha256
> +        (base32
> +         "1w0xghfljqg31axcnv8gzlrd8pw25nji6idnrhflq0af9qh1dw03"))))
> +    (build-system emacs-build-system)
> +    (inputs
> +     `(("emacs-markdown-mode" ,emacs-markdown-mode)
> +       ("let-alist" ,let-alist)))

All emacs dependencies should be propagated, otherwise the package will
not work.

> +    (home-page "https://github.com/vermiculus/sx.el/";)
> +    (synopsis "Emacs StackExchange client")
> +    (description
> +     "Emacs StackExchange client.  Ask and answer questions on
> +Stack Overflow, Super User, and other StackExchange sites.")
> +    (license license:gpl3+)))
> +
>  (define-public emacs-f
>    (package
>      (name "emacs-f")

Also for those who may wonder, there are a lot of errors like this:

  sx-method.el:33:1:Error: Creating directory: No such file or directory, 
/homeless-shelter/.emacs.d/.sx

This leads to many uncompiled elisp files.  This issue is fixed in
master so it should be OK in the next release:

https://github.com/vermiculus/sx.el/commit/53816e1885df22391ecc820297c1fe7cd381a630

-- 
Alex