[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/1] gnu: address@hidden: Make __DATE__ and __TIME__ macros r
|
From: |
Marius Bakke |
|
Subject: |
Re: [PATCH 0/1] gnu: address@hidden: Make __DATE__ and __TIME__ macros reproducible. |
|
Date: |
Mon, 23 Jan 2017 20:56:57 +0100 |
|
User-agent: |
Notmuch/0.23.5 (https://notmuchmail.org) Emacs/25.1.1 (x86_64-unknown-linux-gnu) |
Ludovic Courtès <address@hidden> writes:
>> They *should* be functionally identical to Debians patches:
>>
>> https://anonscm.debian.org/viewvc/gcccvs/branches/sid/gcc-5/debian/patches/
>>
>> ...but I have not verified this. Any takers?
>
> The ‘guix environment’ session you show is exactly how I would have
> tested it, so I don’t think there’s more to be tested, is there?
Was mostly afraid to have missed something, but I could not spot any
differences :)
> I’d only keep the subject line of the patch rather than the complete
> log, to keep it small. We have the upstream commit URL anyway.
>
> Apart from that, LGTM for ‘core-updates’.
OK, pushed with that change!
>
> Next we can remove all those __DATE__/__TIME__ snippets and dance!
>
> Thank you!
>
> Ludo’.
signature.asc
Description: PGP signature