[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH core-updates 6/6] utils: Add helper method to make files writ
From: |
Marius Bakke |
Subject: |
Re: [PATCH core-updates 6/6] utils: Add helper method to make files writable. |
Date: |
Thu, 26 Jan 2017 22:21:20 +0100 |
User-agent: |
Notmuch/0.23.5 (https://notmuchmail.org) Emacs/25.1.1 (x86_64-unknown-linux-gnu) |
Ludovic Courtès <address@hidden> writes:
> Marius Bakke <address@hidden> skribis:
>
>> * gnu/build/activation.scm (make-file-writable): Move this to ...
>> * guix/build/utils.scm (make-file-writable): ... here. Export it.
>> * guix/build/gnu-build-system.scm (strip): Use it.
>
> [...]
>
>> --- a/guix/build/gnu-build-system.scm
>> +++ b/guix/build/gnu-build-system.scm
>> @@ -393,8 +393,10 @@ makefiles."
>> (or (elf-file? file) (ar-file? file))
>> (or (not debug-output)
>> (make-debug-file file))
>> - ;; Ensure libraries are writable.
>> - (chmod file #o755)
>> +
>> + ;; Ensure the file is writable.
>> + (make-file-writable file)
>
> The return value of ‘chmod’ and ‘make-file-writable’ is unspecified, so
> you need to write:
>
> (begin (make-file-writable file) #t)
Thanks! Somehow I missed that "and" block... :(
>
>> +(define (make-file-writable file)
>> + "Make FILE writable for its owner.."
> ^
> Take it as an opportunity to remove this extra period. :-)
>
> Otherwise LGTM.
Pushed!
signature.asc
Description: PGP signature
- [PATCH core-updates 0/6] Wait up!, Marius Bakke, 2017/01/25
- [PATCH core-updates 2/6] gnu: xorg-server: Use 'modify-phases' syntax., Marius Bakke, 2017/01/25
- [PATCH core-updates 4/6] gnu: xf86-video-qxl: Change to libxfont2 ABI., Marius Bakke, 2017/01/25
- [PATCH core-updates 1/6] gnu: Add libxfont2., Marius Bakke, 2017/01/25
- [PATCH core-updates 5/6] gnu: xf86-video-intel: Update to 2.99.917-2-028c946., Marius Bakke, 2017/01/25
- [PATCH core-updates 3/6] gnu: xorg-server: Update to 1.19.1., Marius Bakke, 2017/01/25
- [PATCH core-updates 6/6] utils: Add helper method to make files writable., Marius Bakke, 2017/01/25
- Re: [PATCH core-updates 0/6] Wait up!, Leo Famulari, 2017/01/25