guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 0/5] Add emacs-mu4e-alert.


From: Alex Kost
Subject: Re: [PATCH v2 0/5] Add emacs-mu4e-alert.
Date: Sat, 28 Jan 2017 12:42:49 +0300
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)

Mathieu Othacehe (2017-01-27 14:43 +0100) wrote:

> The point of this serie is to add mu4e-alert and it's dependencies.
> I used the importer for every package and rewrote incorrect descriptions.
>
> Changelog:
> *v2: Replace melpa repositories by github repositories.
>
> Mathieu Othacehe (5):
>   gnu: Add emacs-ht.
>   gnu: Add emacs-log4e.
>   gnu: Add emacs-gntp.
>   gnu: Add emacs-alert.
>   gnu: Add emacs-mu4e-alert.
>
>  gnu/packages/emacs.scm | 130 
> +++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 130 insertions(+)

Thanks, I have added a copyright line for you in the beginning of
"gnu/packages/emacs.scm" and committed these patches.  I have 2 major
notes:

1) Please check the licenses, as they are not necessarily gpl3+.

2) Make sure to run "guix lint" next time ;-)

As there were several warnings reported by:

  guix lint emacs-mu4e-alert emacs-alert emacs-gntp emacs-log4e emacs-ht

particularly, double spaces between sentences, synopsis shouldn't end
with a space, and about source file names.

-- 
Alex



reply via email to

[Prev in Thread] Current Thread [Next in Thread]