Re: [PATCH] gnu: Add cool-retro-term.

[Chris Marusich]

Petter <address@hidden> writes:

> Hi Guix,
>
> The past is finally here! Had a go at packaging a terminal emulator
> which mimics old cathode displays :)

Wow!!  This is really fun.  Thanks for packaging it!

> +       (modify-phases %standard-phases
> +         (replace 'configure
> +                  (lambda* (#:key outputs #:allow-other-keys)
> +                    (let ((out (assoc-ref outputs "out")))
> +                      (substitute* '("qmltermwidget/qmltermwidget.pro")
> +                        (("INSTALL_DIR = \\$\\$\\[QT_INSTALL_QML\\]")
> +                         (string-append "INSTALL_DIR = " out "/qml")))
> +                      (substitute* '("app/app.pro")
> +                        (("target.path \\+= /usr")
> +                         (string-append "target.path += " out))
> +                        (("icon32.path = /usr/share")
> +                         (string-append "icon32.path = " out))
> +                        (("icon64.path = /usr/share")
> +                         (string-append "icon64.path = " out))
> +                        (("icon128.path = /usr/share")
> +                         (string-append "icon128.path = " out))
> +                        (("icon256.path = /usr/share")
> +                         (string-append "icon256.path = " out)))
> +                      (zero? (system* "qmake")))))

Should these icons be put somewhere else, like in the $out/share path?
If it works, it works, though.  (info '(standards) Directory Variables'):

> +    (synopsis "terminal emulator which mimics the look and feel of the old
> +cathode tube screens")
> +    (description
> +     "Cool-retro-term is a terminal emulator which mimics the look and feel 
> of
> +the old cathode tube screens. It has been designed to be eye-candy,
> +customizable, and reasonably lightweight.")

Just minor feedback: Maybe use the phrases "CRT" and "cathode ray tube"
to make this easier to discover?

-- 
Chris

signature.asc
Description: PGP signature