Re: Internship on Improve the user experience for the "guix package" command line tool (Outreachy)

[Ricardo Wurmus]

Hi Vijayalakshmi,

> I created a patch file for the package definition of python-logwrap that
> I'm including here. I'm a little unsure if my patch is right because my ./
> pre-inst-env.in guix build r-abbyyR fails with some error.

Have you been able to build Guix already and try building the package
using “./pre-inst-env guix build”?

I looked over your patch for python-logwrap.  I had to append “.zip”
because Pypi didn’t have a “.tar.gz” file for the sources, so the uri
field now is:

   (pypi-uri "logwrap" version ".zip")

Having a zip archive requires the “unzip” command during the “unpack”
phase, so I also added “unzip” to the native-inputs field.

I also noticed that the sources include files that were generated with
Cython.  Instead of reusing those, we build them from source.  Luckily
all we have to do in this case is to add “python-cython” to the
native-inputs field.

Finally, the tests. At first the tests wouldn’t run.  So I looked up the
error message online and found that I need to use “python-pytest-runner”
in addition to “python-pytest”.  This allows the tests to run up to a
point until it wants to do coverage tests.  For those I needed to add
“python-pytest-cov”.

I changed the description, because I think it wasn’t quite correct.

Attached is my modified version.  What do you think?  Do you have any
questions about my changes?

>From 520d4cd8d9246ec4a1601906404194610f3905bd Mon Sep 17 00:00:00 2001
From: Vijayalakshmi <address@hidden>
Date: Mon, 19 Mar 2018 22:20:25 +0530
Subject: [PATCH] gnu: Add python-logwrap.

* gnu/packages/python.scm (python-logwrap): New variable.

Co-authored-by: Ricardo Wurmus <address@hidden>
---
 gnu/packages/python.scm | 30 +++++++++++++++++++++++++++++-
 1 file changed, 29 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 76b5460f6..ff250a1ea 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -47,7 +47,8 @@
 ;;; Copyright © 2017 Brendan Tildesley <address@hidden>
 ;;; Copyright © 2018 Ethan R. Jones <address@hidden
 ;;; Copyright © 2018 Fis Trivial <address@hidden>
-;;;
+;;; Copyright © 2018 Vijayalakshmi Vedantham <address@hidden>
+
 ;;; This file is part of GNU Guix.
 ;;;
 ;;; GNU Guix is free software; you can redistribute it and/or modify it
@@ -524,6 +525,33 @@ pidof, tty, taskset, pmap.")
 planar geometric objects.  It is based on the @code{GEOS} library.")
     (license license:bsd-3)))
 
+(define-public python-logwrap
+  (package
+    (name "python-logwrap")
+    (version "3.2.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "logwrap" version ".zip"))
+       (sha256
+        (base32
+         "1d2k0hvpbi51vl410y8fbs5m0nxnlh2k7gr2nrh3k81ibhzscsra"))))
+    (build-system python-build-system)
+    (propagated-inputs
+     `(("python-six" ,python-six)
+       ("python-typing" ,python-typing)))
+    (native-inputs
+     `(("unzip" ,unzip)
+       ("python-cython" ,python-cython)
+       ("python-pytest" ,python-pytest)
+       ("python-pytest-cov" ,python-pytest-cov)
+       ("python-pytest-runner" ,python-pytest-runner)))
+    (home-page "https://github.com/penguinolog/logwrap";)
+    (synopsis "Decorator for logging function arguments")
+    (description "This package provides a decorator to log function arguments
+and function call return values in a human-readable way.")
+    (license license:asl2.0)))
+
 (define-public python2-shapely
   (package-with-python2 python-shapely))
 
-- 
2.16.2

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net