[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Fwd: Re: Patch file for colorize module
From: |
Ricardo Wurmus |
Subject: |
Re: Fwd: Re: Patch file for colorize module |
Date: |
Wed, 13 Jun 2018 21:15:26 +0200 |
User-agent: |
mu4e 1.0; emacs 26.1 |
Hi Sahithi,
>> Do you see this too? (If not, can you tell us what terminal you are
>> using?) At the very least you should see that every line starts with a
>> dot.
> I am able to see the colours. I tested with the same hello package
> before sending you the patch. And yes "." for each line.
Good!
>> The next steps are to fix the errors in the regular expressions that
>> swallow certain space characters and to re-read the documentation of
>> “make-soft-port” to make sure that the procedures in the vector behave
>> as they should.
> I will update back once i am through with it.
After reading the documentation for “make-soft-port” again, I recommend
adding very short comments above each of the procedures in the vector to
explain what they are intended to do.
This is generally good practice when working with facilities that don’t
provide named / keyword arguments.
--
Ricardo
- Re: Fwd: Re: Patch file for colorize module, (continued)
- Re: Fwd: Re: Patch file for colorize module, Ricardo Wurmus, 2018/06/08
- Re: Fwd: Re: Patch file for colorize module, Sahitihi, 2018/06/09
- Re: Fwd: Re: Patch file for colorize module, Ricardo Wurmus, 2018/06/12
- Re: Fwd: Re: Patch file for colorize module, Sahitihi, 2018/06/11
- Re: Fwd: Re: Patch file for colorize module, Gábor Boskovits, 2018/06/11
- Re: Fwd: Re: Patch file for colorize module, Sahitihi, 2018/06/11
- Re: Fwd: Re: Patch file for colorize module, Ricardo Wurmus, 2018/06/12
- Re: Fwd: Re: Patch file for colorize module, Sahitihi, 2018/06/12
- Re: Fwd: Re: Patch file for colorize module, Ricardo Wurmus, 2018/06/12
- Re: Fwd: Re: Patch file for colorize module, Sahithi Yarlagadda, 2018/06/13
- Re: Fwd: Re: Patch file for colorize module,
Ricardo Wurmus <=
- Re: Fwd: Re: Patch file for colorize module, Sahitihi, 2018/06/15
- Next steps, Ricardo Wurmus, 2018/06/15
- Re: Next steps, Sahitihi, 2018/06/16
- Re: Next steps, Ricardo Wurmus, 2018/06/22
- Re: Next steps, Sahithi Yarlagadda, 2018/06/21
- Re: Next steps, Sahithi Yarlagadda, 2018/06/25
- Re: Next steps, Ricardo Wurmus, 2018/06/25
- Re: Next steps, Gábor Boskovits, 2018/06/26
- Re: Next steps, Sahithi Yarlagadda, 2018/06/29
- Re: Next steps, Sahithi Yarlagadda, 2018/06/24