guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Patchwork + automated checking and testing of patches


From: Christopher Baines
Subject: Re: Patchwork + automated checking and testing of patches
Date: Fri, 08 Feb 2019 12:04:20 +0000
User-agent: mu4e 1.0; emacs 26.1

Ludovic Courtès <address@hidden> writes:

> Heya!
>
> Christopher Baines <address@hidden> skribis:
>
>> So, today at the Guix Days event in Brussels I've made a small change to
>> the Laminar configuration related to patchwork.cbaines.net.
>
> Damn it, I didn’t know you had done that while we were there, kudos!
>
>> Now, when processing a series of patches, it should create a Git branch
>> and push it to a repository.
>>
>> For example, for this patch series [1], you can see it being processed
>> here [2]. The result of applying the patches is pushed up to this Git
>> repository [3], and you can see the commit range here [4].
>>
>> 1: https://patchwork.cbaines.net/project/guix-patches/list/?series=482
>> 2: https://laminar.cbaines.net/jobs/patchwork-test-series/826
>> 3: https://git.cbaines.net/guix/patches/log/?h=series-482-version-1
>> 4: 
>> https://git.cbaines.net/guix/patches/log/?h=series-482-version-1&qt=range&q=base-for-series-482-version-1..series-482-version-1
>
> Neat!

Thanks, however, one thing I've noticed is that git apply seems to be
much more reliable at applying patches than git am. It often fails with
"Patch is empty".

I'm not sure why, it seems to work for the patches I've sent with git
send-email, but maybe it's very particular about the formatting...

>> I'm hoping that having the patches in a Git repository can enable using
>> things like `guix pull` to build a Guix with the patches to then extract
>> information about what's changed, as well as potentially being useful
>> for getting Cuirass to build things...
>
> Yup, this is really promising, looks like you’re getting there!  As
> discussed at the Greek restaurant, it’d be nice to see how much of the
> job Laminar runs can be turned into (guix …) modules, though that can
> come later.
>
> Anyway, as this is shaping up, let us know if you need input on the
> remaining bits, like using the channel API to extract information about
> the new branch, or fiddling with Cuirass.

I've made a bit more progress with this over the last couple of days,
I'll start another thread for that though.

Thanks,

Chris

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]