[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#26391: [PATCH 0/1] Patching getcap and which in torsocks
From: |
Ludovic Courtès |
Subject: |
bug#26391: [PATCH 0/1] Patching getcap and which in torsocks |
Date: |
Sat, 08 Apr 2017 14:28:23 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Hi Eric,
Eric Bavier <address@hidden> skribis:
> This patches references to the 'getcap' and 'which' programs in 'torsocks'
> so that users that don't have either of those packages installed in their
> profiles do not see confusing output about them missing. Usually torsocks
> will still function in that case, but it's probably better to have them
> available.
>
> I've so far done this sort of thing for several packages with shell scripts,
> and each time I'm convinced that this method is better than declaring the
> inputs in propagated-inputs. But I think I'd feel more sure of myself if we
> had a short "Packaging shell scripts" section in the manual that outlined
> best-practices-of-the-moment. Would that be useful?
Yes, sure.
> * gnu/packages/tor.scm (torsocks)[inputs,arguments]: New fields.
LGTM, thanks!
Ludo’.