bug#26815: [PATCH 2/3] vm: Support creating FAT partitions.

[Marius Bakke]

Danny Milosavljevic <address@hidden> writes:

> Hi Marius,
>
> On Sun, 07 May 2017 17:52:43 +0200
> Marius Bakke <address@hidden> wrote:
>
>> I had that first, but the error handling was exactly identical, so opted
>> to just handle it in the caller. It does sound safer to handle errors
>> there instead of passing system* around though, will do that in lieu of
>> other comments. 
>
> Yeah, I did that in the past, too (and for many things still do).  But this 
> procedure is critical enough that ignoring the return value would do some 
> very strange things - and for those I lately do defensive programming.
>
>> > "format-procedure" is not actually the procedure, right? It's already the 
>> > formatting-status ...  
>> 
>> Oops, an artifact of rebasing a lot of revisions...
>
> Your v2 patch still calls it that :)

D'oh. It could of course be much simpler after removing the error
handling too..

v3 attached.

0001-vm-Support-creating-FAT-partitions.patch
Description: Text Data

signature.asc
Description: PGP signature