[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#26815: [PATCH 3/3] vm: Add UEFI loader to disk images.
From: |
Ludovic Courtès |
Subject: |
bug#26815: [PATCH 3/3] vm: Add UEFI loader to disk images. |
Date: |
Wed, 10 May 2017 23:05:35 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Hi Marius,
Marius Bakke <address@hidden> skribis:
> * gnu/system/vm.scm (qemu-image): Add GRUB-EFI to inputs. Append 40MiB EFI
> System Partition.
> * gnu/build/vm.scm (install-efi): New procedure.
> (initialize-hard-disk): Generate grub EFI blob when ESP is present.
[...]
> +(define (install-efi esp grub.cfg)
> + "Write a self-contained Grub UEFI blob to the mounted ESP using GRUB.CFG."
I’m really nitpicking here, but the spelling is “GRUB”. :-)
> + (with-output-to-file grub.cfg
> + (lambda _
> + (format #t
> + "insmod part_msdos~@
Nitpicking too, but I have a preference for the more explicit:
(call-with-output-file grub.cfg
(lambda (port)
(format port …)))
Otherwise the whole series LGTM.
Do I get it right that ‘disk-image’ will now give us UEFI-enabled
images? (Should we mention it in guix.texi?)
Thanks a lot!
Ludo’.
- bug#26815: [PATCH 1/3] vm: Add support for arbitrary partition flags., (continued)
- bug#26815: [PATCH 1/3] vm: Add support for arbitrary partition flags., Marius Bakke, 2017/05/07
- bug#26815: [PATCH 3/3] vm: Support EFI boot in base image., Marius Bakke, 2017/05/07
- bug#26815: [PATCH 3/3] vm: Support EFI boot in base image., Danny Milosavljevic, 2017/05/07
- bug#26815: [PATCH 3/3] vm: Support EFI boot in base image., Marius Bakke, 2017/05/07
- bug#26815: [PATCH 3/3] vm: Support EFI boot in base image., Marius Bakke, 2017/05/07
- bug#26815: [PATCH 3/3] vm: Support EFI boot in base image., Marius Bakke, 2017/05/08
- bug#26815: [PATCH 3/3] vm: Support EFI boot in base image., Ludovic Courtès, 2017/05/08
- bug#26815: [PATCH 1/3] vm: Support arbitrary partition flags., Marius Bakke, 2017/05/10
- bug#26815: [PATCH 2/3] vm: Support creating FAT partitions., Marius Bakke, 2017/05/10
- bug#26815: [PATCH 3/3] vm: Add UEFI loader to disk images., Marius Bakke, 2017/05/10
- bug#26815: [PATCH 3/3] vm: Add UEFI loader to disk images.,
Ludovic Courtès <=
- bug#26815: [PATCH 3/3] vm: Add UEFI loader to disk images., Marius Bakke, 2017/05/10
- bug#26815: [PATCH 3/3] vm: Support EFI boot in base image., Marius Bakke, 2017/05/10
- bug#26815: [PATCH 3/3] vm: Support EFI boot in base image., Ludovic Courtès, 2017/05/12
- bug#26815: [PATCH 3/3] vm: Support EFI boot in base image., Marius Bakke, 2017/05/12
- bug#26815: [PATCH 3/3] vm: Support EFI boot in base image., Mathieu Othacehe, 2017/05/13
- bug#26815: [PATCH 3/3] vm: Support EFI boot in base image., Ludovic Courtès, 2017/05/13
- bug#26815: [PATCH 3/3] vm: Support EFI boot in base image., Marius Bakke, 2017/05/13
- bug#26815: [PATCH 3/3] vm: Support EFI boot in base image., Ludovic Courtès, 2017/05/13
- bug#26815: [PATCH 3/3] vm: Support EFI boot in base image., Ludovic Courtès, 2017/05/16
- bug#26815: [PATCH 3/3] vm: Support EFI boot in base image., Marius Bakke, 2017/05/17