guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#27081: [PATCH 1/2] gnu: Add python-packaging.


From: Marius Bakke
Subject: bug#27081: [PATCH 1/2] gnu: Add python-packaging.
Date: Fri, 26 May 2017 15:11:15 +0200
User-agent: Notmuch/0.24.1 (https://notmuchmail.org) Emacs/25.2.1 (x86_64-unknown-linux-gnu)

Leo Famulari <address@hidden> writes:

> ---
>  gnu/packages/python.scm | 31 +++++++++++++++++++++++++++++++
>  1 file changed, 31 insertions(+)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 62fada66a..e7dba73c6 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -14676,3 +14676,34 @@ JSON APIs with Behave.")
>  
>  (define-public python2-behave-web-api
>    (package-with-python2 python-behave-web-api))
> +
> +(define-public python-packaging
> +  (package
> +    (name "python-packaging")
> +    (version "16.8")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (pypi-uri "packaging" version))
> +        (sha256
> +         (base32
> +          "17k1xbjshackwvbsnxqixbph8rbqhz4bf4g3al5xyzhavxgq6l2x"))))
> +    (build-system python-build-system)
> +    (native-inputs
> +     `(("python-pretend" ,python-pretend)
> +       ("python-pytest" ,python-pytest)))
> +    (propagated-inputs
> +     `(("python-pyparsing" ,python-pyparsing)
> +       ("python-six" ,python-six)))
> +    (home-page "https://github.com/pypa/packaging";)
> +    (synopsis "Core utilities for Python packages")
> +    (description "Packaging is a Python module for dealing with Python 
> packages.
> +It offers an interface for working with package versions, names, and 
> dependency
> +information.")
> +;;; From 'LICENSE': This software is made available under the terms of 
> *either*
> +;;; of the licenses found in LICENSE.APACHE or LICENSE.BSD. Contributions to
> +;;; this software is made under the terms of *both* these licenses.

Please only use two semicolons here, with indentation. IMO the "triple
semicolons" are for "meta-commentary" about the module, not for code
comments.

Other than that looks good. As a side note, I typically don't append to
modules since the patch context quickly becomes outdated (like now), but
that's another issue entirely :-)

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]