[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#27520] [PATCH] build: Use "GUIXSD" as root label.

From: Danny Milosavljevic
Subject: [bug#27520] [PATCH] build: Use "GUIXSD" as root label.
Date: Sun, 2 Jul 2017 12:05:57 +0200

Hi Ludo,

On Thu, 29 Jun 2017 18:18:03 +0200
address@hidden (Ludovic Courtès) wrote:

> So what about literally “GuixSD” and then using ‘string-upcase’ in the
> ISO9660 code?  That would avoid the all-caps style on all the other file
> systems, which is a good thing.

As the code is written, it would be best and least confusing if 
gnu/build/file-systems.scm partition-label-predicate then just said

(define partition-label-predicate
  (partition-predicate read-partition-label string-ci=?))

instead of

(define partition-label-predicate
  (partition-predicate read-partition-label string=?))

, i.e. if it was done for all the filesystems.

Other alternatives are
- Implementing support for the Joliet extension just to get get lowercase 
letters on CDs
- Ignoring the problem and putting the lowercase letters in the primary volume 
name on CD anyway, using ISO-9660.  After all it's just forbidden, not 

I personally favor just actually using all uppercase letters as the label.  
Everything else makes it just needlessly complicated.

That said, the right fix would be to use the UUID instead of the label for 
finding the root filesystem.  Using the label isn't really safe anyway - 
whereas a random UUID should be preeeeeeetty safe.

I'm testing passing the UUID now.  Let's see...

reply via email to

[Prev in Thread] Current Thread [Next in Thread]