[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#27521] [PATCH] guix system: Add "--file-system-type" option.

From: Ludovic Courtès
Subject: [bug#27521] [PATCH] guix system: Add "--file-system-type" option.
Date: Mon, 03 Jul 2017 13:56:40 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)

Danny Milosavljevic <address@hidden> skribis:

> * guix/scripts/system.scm (process-action): Pass file-system-type to ...
> (perform-action): ... here.  Add new keyword argument.  Pass new value to ...
> (system-derivation-for-action): ... here.  Add new keyword argument.
> Pass new value to system-disk-image.
> * doc/guix.texi (disk-image): Document new option.
> ---
>  doc/guix.texi           |  3 +++
>  guix/scripts/system.scm | 23 +++++++++++++++++++----
>  2 files changed, 22 insertions(+), 4 deletions(-)
> diff --git a/doc/guix.texi b/doc/guix.texi
> index d61a5b751..25354b8c9 100644
> --- a/doc/guix.texi
> +++ b/doc/guix.texi
> @@ -16190,6 +16190,9 @@ in @var{file} that stands alone.  By default, 
> @command{guix system}
>  estimates the size of the image needed to store the system, but you can
>  use the @option{--image-size} option to specify a value.
> +You can specify the root file system type by using the
> address@hidden option.  It defaults to "ext4".


You also need to add an @item for --file-system-type in the option

Also, it might be good to add examples of other supported values, like:

  @cindex ISO-9660 format
  @cindex CD image format
  @cindex DVD image format
  @code{--file-system-type=iso9660} produces an ISO-9660 image, suitable
  for burning on CDs and DVDs.

> +         (option '(#\f "file-system-type") #t #f
> +                 (lambda (opt name arg result)
> +                   (alist-cons 'file-system-type arg
> +                               result)))

I’m not sure we want to use the “-f” shortcut here.  Initially I thought
we’d have -f/--format for the image format, i.e., qcow2 vs. raw (are
there any others?).


Besides, I think “guix system disk-image --file-system-format=foobarbaz”
fails badly, but I’m not sure how to fix it without having to maintain a
list of valid file system names.  Maybe we should just ignore this



reply via email to

[Prev in Thread] Current Thread [Next in Thread]