guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#27616] [PATCH] gnu: you-get: Update to 0.4.775.


From: Ben Woodcroft
Subject: [bug#27616] [PATCH] gnu: you-get: Update to 0.4.775.
Date: Sat, 8 Jul 2017 22:37:13 +1000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1

Hi Feng, thanks for the patch.


On 08/07/17 21:53, Feng Shu wrote:
-    (version "0.4.715")
+    (version "0.4.775")
     (source (origin
               (method url-fetch)
               (uri (string-append
-                    "https://github.com/soimort/you-get/releases/download/v"
-                    version "/you-get-" version ".tar.gz"))
+                    "https://github.com/soimort/you-get/archive/v"
+                    version ".tar.gz"))
Here, the downloaded filename is "v0.4.775.tar.gz", which doesn't contain "you-get" anymore (we prefer it does so the base directory doesn't fill with opaque names, and this is checked by 'guix lint'). We usually fix this by adding

(file-name (string-append name "-" version ".tar.gz"))

to the package definition. However, is there some reason why the URL scheme should be changed? Alternatively, we could also source this package from PyPI given that is recommended on the you-get website. WDYT?

Thanks, ben.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]