[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#28322] [PATCH] gnu: Add stgit.

From: Marius Bakke
Subject: [bug#28322] [PATCH] gnu: Add stgit.
Date: Sat, 02 Sep 2017 12:57:50 +0200
User-agent: Notmuch/0.25 ( Emacs/25.2.1 (x86_64-unknown-linux-gnu)

Stefan Reichör <address@hidden> writes:

> * gnu/packages/version-control.scm (stgit): New variable.


> +(define-public stgit
> +  (package
> +    (name "stgit")
> +    (version "0.18")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append 
> "";
> +                                  version ".tar.gz"))
> +              (file-name (string-append name "-" version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "19fk6vw3pgp2a98wpd4j3kyiyll5dy9bi4921wq1mrky0l53mj00"))))
> +    (build-system python-build-system)
> +    (inputs
> +     `(("git" ,git)))

I noticed this package does not contain any references to git.  Check
with `guix gc -R $(./pre-inst-env guix build stgit)`.

Can you see if it's possible to embed the full path to the `git`
executable somehow, so that users don't need to install it separately?
Either by embedding the full path in the code directly (preferred), or
wrapping the stg executable with git in PATH.

It would also be good to run the tests by adding a phase that runs
`python t/` according to "tox.ini".  Can you try that?

Thanks in advance!

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]