[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#28285] Add heimdall

From: Ludovic Courtès
Subject: [bug#28285] Add heimdall
Date: Mon, 04 Sep 2017 16:22:55 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)


Julien Lepiller <address@hidden> skribis:

> I had to change the import of licenses and license field of all
> packages because heimdall depends on zlib, which is also a license
> name. Should I mention that in the commit message too? Should it be in
> a separate commit?

IMO it’s marginely better as a separate commit, but no big deal.

> From 77a0831ce91b61eca537d197e9c15720b3b6cf7e Mon Sep 17 00:00:00 2001
> From: Julien Lepiller <address@hidden>
> Date: Tue, 29 Aug 2017 23:54:16 +0200
> Subject: [PATCH] gnu: Add heimdall.
> * gnu/packages/flashing-tools.scm (heimdall): New variable.


> +         (replace 'install
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let ((bin (string-append (assoc-ref outputs "out") "/bin")))
> +               (mkdir-p bin)
> +               (copy-file "bin/heimdall" (string-append bin "/heimdall"))
> +               (copy-file "bin/heimdall-frontend"
> +                          (string-append bin "/heimdall-frontend"))

You can write these as:

  (install-file "bin/heimdall" bin)

and also remove (mkdir-p bin).

OK with these changes!


reply via email to

[Prev in Thread] Current Thread [Next in Thread]