[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#28288] [PATCH 1/5] vm: Add support for registering closures to make
[bug#28288] [PATCH 1/5] vm: Add support for registering closures to make-iso9660-image.
Wed, 06 Sep 2017 15:20:44 +0200
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)
Christopher Baines <address@hidden> skribis:
> On Tue, 05 Sep 2017 15:17:32 +0200
> address@hidden (Ludovic Courtès) wrote:
>> Christopher Baines <address@hidden> skribis:
>> > This mimics the functionality in the root-partition-initializer
>> > used in creating the QEMU image. This helps when trying to run guix
>> > system init from the generated ISO image.
>> > * gnu/build/vm.scm (make-iso9660-image): Add support for
>> > registering closures.
>> > + (when register-closures?
>> > + (display "registering closures...\n")
>> > + (for-each (lambda (closure)
>> > + (register-closure
>> > + "/tmp/root"
>> > + (string-append "/xchg/" closure)
>> > + #:deduplicate? #f))
>> > + closures))
>> Was there any specific reason for #:deduplicate? #f here?
> Yep, the image creation process fails if this is not specified.
> error: cannot link
> Invalid cross-device link
Hmm, OK. Looks like it’s trying to deduplicate between /tmp/root and
some other store. (Or are we using a bind mount here?)
> There is probably another way around this though. I'm not sure what
> impact skipping the deduplication has on the size of the image.
It probably doesn’t matter much, so it’s not a blocker IMO.
Maybe leave an XXX comment mentioning the cross-device link issue.