guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#29878] [PATCH] gnu: Add emacs-evil-smartparens.


From: Arun Isaac
Subject: [bug#29878] [PATCH] gnu: Add emacs-evil-smartparens.
Date: Tue, 02 Jan 2018 18:10:21 +0530

> I didn't run it because I can't use Vi(m) so maybe it's better if someone
> else tests this

I do use this package. I installed it and checked. It works properly,
and I'm quite confident there are no issues. It's a very trivial
package, after all.

> I would say
>
> @code{emacs-evil-smartparens} is an Emacs minor mode which
> makes Evil, the Emacs mode to simulate the Vi key combinations, play nice
> with Smartparens.
>
> I wouldn't assume that people reading the description know what Evil is
> Or, maybe a link to the Evil home page would be better, instead of a quite
> long sentence between commas ?

In the new patch I just sent, I have added a second sentence explaining
what Evil is. I don't think it's very useful to add a link in the
description text. IMHO, descriptions are better if they are
self-contained. The user can always search on the web if they want to
know more.

> Thanks !

Thanks for the review!





reply via email to

[Prev in Thread] Current Thread [Next in Thread]