[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#29932] [PATCH 0/2] Clean up operating-system-kernel-arguments.
From: |
Danny Milosavljevic |
Subject: |
[bug#29932] [PATCH 0/2] Clean up operating-system-kernel-arguments. |
Date: |
Tue, 9 Jan 2018 11:39:54 +0100 |
> It’d feel more idiomatic to me if, instead, we had an
> ‘operating-system-boot-kernel-arguments’ procedure that takes an OS and
> returns (list --root --system …). Then it’d be up to the caller to
> append that to what ‘operating-system-kernel-arguments’ returns.
We could also do that...
Note that bootable-kernel-arguments is also used by this:
(define (read-boot-parameters-file system)
"Read boot parameters from SYSTEM's (system or generation) \"parameters\"
file and returns the corresponding <boot-parameters> object or #f if the
format is unrecognized.
The object has its kernel-arguments extended in order to make it bootable."
(let* ((file (string-append system "/parameters"))
(params (call-with-input-file file read-boot-parameters))
(root (boot-parameters-root-device params))
(kernel-arguments (boot-parameters-kernel-arguments params)))
(if params
(boot-parameters
(inherit params)
(kernel-arguments (bootable-kernel-arguments kernel-arguments
system root)))
#f)))
Which is used by the ./guix/scripts/system.scm generation lister etc (that is,
they have the derivations already).
[bug#29932] [PATCH v2 1/2] system: Split up operating-system-kernel-arguments into operating-system-boot-kernel-arguments and operating-system-user-kernel-arguments., Danny Milosavljevic, 2018/01/12