[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#30598] [PATCH 0/5] gnu: Add youtube-viewer.
From: |
Alex Vong |
Subject: |
[bug#30598] [PATCH 0/5] gnu: Add youtube-viewer. |
Date: |
Tue, 27 Feb 2018 03:30:18 +0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
Marius Bakke <address@hidden> writes:
> Alex Vong <address@hidden> writes:
>
>> Tags: patch
>>
>> Hello,
>>
>> This patch series adds youtube-viewer and its dependencies. It can be
>> used for searching youtube videos without running javascript. It also
>> plays nice with tor which is a plus.
>
> Thanks for this series! The patches LGTM, but can you move the perl
> packages to gtk.scm and glib.scm respectively? That seems more
> appropriate, as we already have e.g. pygtk in gtk.scm, and also avoids
> some top-module cross-references.
>
> (Additionally, perl.scm is huge, so it's good to spread the load to
> appease the Guile compiler)
>
> Thanks in advance! :-)
(I messed up my mail settings, so I am re-sending.)
The next patch series should fix everything you've mentioned so far. I
don't understand why wrap-program is used before but now I do.
Thanks for your review also!
signature.asc
Description: PGP signature
- [bug#30598] [PATCH 0/5] gnu: Add youtube-viewer., Alex Vong, 2018/02/24
- [bug#30598] [PATCH 1/5] gnu: Add perl-cairo., Alex Vong, 2018/02/24
- [bug#30598] [PATCH 2/5] gnu: Add perl-glib., Alex Vong, 2018/02/24
- [bug#30598] [PATCH 3/5] gnu: Add perl-pango., Alex Vong, 2018/02/24
- [bug#30598] [PATCH 4/5] gnu: Add perl-gtk2., Alex Vong, 2018/02/24
- [bug#30598] [PATCH 5/5] gnu: Add youtube-viewer., Alex Vong, 2018/02/24
- [bug#30598] [PATCH 0/5] gnu: Add youtube-viewer., Marius Bakke, 2018/02/25
- [bug#30598] [PATCH 0/5] gnu: Add youtube-viewer.,
Alex Vong <=
- [bug#30598] [PATCH 2/5] gnu: Add perl-glib., Alex Vong, 2018/02/26
- [bug#30598] [PATCH 1/5] gnu: Add perl-cairo., Alex Vong, 2018/02/26
- [bug#30598] [PATCH 3/5] gnu: Add perl-pango., Alex Vong, 2018/02/26
- [bug#30598] [PATCH 4/5] gnu: Add perl-gtk2., Alex Vong, 2018/02/26
- [bug#30598] [PATCH 5/5] gnu: Add youtube-viewer., Alex Vong, 2018/02/26