[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#30765] [PATCH] gnu: qtox: Propagate qtsvg and fix misplaced comma (
|
From: |
Ludovic Courtès |
|
Subject: |
[bug#30765] [PATCH] gnu: qtox: Propagate qtsvg and fix misplaced comma (unquote). |
|
Date: |
Mon, 12 Mar 2018 15:42:32 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
Hello Diego,
Diego Nicola Barbato <address@hidden> skribis:
> This patch fixes an issue where qTox failed to display some icons by
> moving qtsvg to propagated-inputs.
> I also took the liberty of fixing a misplaced comma (unquote).
The patch LGTM, but can you explain why propagating qtsvg allows icons
to be displayed?
In general we try to avoid propagated inputs because they “pollute” the
user’s profile, so we should make sure there’s no other solution and add
a comment explaining why we do that.
Thanks!
Ludo’.