[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#30925] [PATCH] gnu: Add emacs-puppet-mode.
From: |
Marius Bakke |
Subject: |
[bug#30925] [PATCH] gnu: Add emacs-puppet-mode. |
Date: |
Mon, 26 Mar 2018 19:54:05 +0200 |
User-agent: |
Notmuch/0.26 (https://notmuchmail.org) Emacs/25.3.1 (x86_64-pc-linux-gnu) |
Christopher Baines <address@hidden> writes:
> * gnu/packages/emacs.scm (emacs-puppet-mode): New variable.
[...]
> +(define-public emacs-puppet-mode
> + (let ((commit "b3ed5057166a4f49dfa9be638523a348b55a2fd2")
> + (revision "1"))
> + (package
> + (name "emacs-puppet-mode")
> + (version (git-version "0.3" revision commit))
Maybe mention why we can't take the 0.3 tag?
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append
> + "https://raw.githubusercontent.com/voxpupuli/puppet-mode/"
> + commit "/puppet-mode.el"))
It would be nice to install the README too, but no strong opinion.
> + (sha256
> + (base32
> + "1indycxawsl0p2aqqg754f6735q3cmah9vd886rpn0ncc3ipi1xm"))))
> + (build-system emacs-build-system)
> + (home-page "https://github.com/voxpupuli/puppet-mode")
> + (synopsis "Emacs major mode for the Puppet configuration language")
> + (description
> + "This package provides support for the Puppet configuration language,
> +including syntax highlighting, indentation of expressions and statements,
> +linting of manifests and integration with Puppet Debugger.")
> + (license license:gpl3+))))
Perhaps mention in a comment that it includes ASL code, as mentioned in
puppet-mode.el.
LGTM otherwise.
signature.asc
Description: PGP signature