[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#31081] [PATCH] gnu: Add emacs-anzu-evil
From: |
Sohom Bhattacharjee |
Subject: |
[bug#31081] [PATCH] gnu: Add emacs-anzu-evil |
Date: |
Sat, 7 Apr 2018 23:47:10 +0530 |
User-agent: |
Mutt/1.9.3 (2018-01-21) |
I have made the suggested changes and attached the new patch.
Thank You :-)
On Sat, Apr 07, 2018 at 07:25:22PM +0300, Oleg Pykhalov wrote:
> Hello Soham,
>
> Sohom Bhattacharjee <address@hidden> writes:
>
> > * gnu/packages/emacs.scm (emacs-anzu-evil): New variable.
> > ---
> > test
> >
> > gnu/packages/emacs.scm | 23 +++++++++++++++++++++++
> > 1 file changed, 23 insertions(+)
> >
> > diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> > index fd0b8acd0..2463d0dab 100644
> > --- a/gnu/packages/emacs.scm
> > +++ b/gnu/packages/emacs.scm
> > @@ -7494,3 +7494,26 @@ used with SGML-like languages: XML, HTML, XHTML,
> > XSL, etc.")
> > standard Unix password manager\").")
> > (license license:gpl2+)))
> >
> > +(define-public emacs-evil-anzu
> > + (package
> > + (name "emacs-evil-anzu")
> > + (version "0.03")
> > + (source
> > + (origin
> > + (method url-fetch)
> > + (uri (string-append
> > "https://github.com/syohex/emacs-evil-anzu/archive/"
> > + version ".tar.gz"))
> > + (file-name (string-append name "-" version ".tar.gz"))
> > + (sha256
> > + (base32 "032hh2946z529cizqsg8pm6cpn5qdj8lfk3qskmx6xv3g2ra56ns"))))
> > + (build-system emacs-build-system)
> > + (propagated-inputs
> > + `(("emacs-evil" ,emacs-evil)
> > + ("emacs-anzu" ,emacs-anzu)))
> > + (home-page
> > + "https://github.com/syohex/emacs-evil-anzu")
> ^
> This string could be on the previous line (‘M-^’ will do it).
>
> > + (synopsis "anzu for evil-mode")
>
> --8<---------------cut here---------------start------------->8---
> $ ./pre-inst-env guix lint emacs-evil-anzu
>
> gnu/packages/emacs.scm:7515:12: address@hidden: synopsis should start with an
> upper-case letter or digit
> --8<---------------cut here---------------end--------------->8---
>
> I think address@hidden will be appropriate.
>
> > + (description "Anzu provides a minor mode that displays the current match
> > and
> > +total match information in the mode-line in various search modes.")
> > + (license license:gpl3+)))
> > +
>
> The whole ‘(define-public emacs-evil-anzu …)’ should be indented. I'm
> not an ‘evil-mode’ user, but in pure Emacs you could do it with ‘M-h’
> and ‘TAB’. Also it will probably require to fill some strings with
> ‘M-q’. Alternatively you use ‘etc/indent-code.el’. See
> https://www.gnu.org/software/guix/manual/html_node/Formatting-Code.html
>
> Thanks,
> Oleg.
0001-gnu-Add-emacs-evil-anzu.patch
Description: Text document