[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#32031] [PATCH] gnu: Add keynav.
From: |
Oleg Pykhalov |
Subject: |
[bug#32031] [PATCH] gnu: Add keynav. |
Date: |
Tue, 03 Jul 2018 07:31:03 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Hello Ludovic,
Thank you for review.
address@hidden (Ludovic Courtès) writes:
> Oleg Pykhalov <address@hidden> skribis:
>
>> * gnu/packages/xorg.scm (keynav): New variable.
>
> [...]
>
>> + (arguments
>> + `(#:tests? #f
>
> Could you leave a comment explaining why tests are skipped? If an X
> server is needed, we can launch Xvfb before the ‘check’ phase, as many
> packages do.
Ah, I should did this in the first place, sorry. There are no tests.
>> + #:phases
>> + (modify-phases %standard-phases
>> + (add-after 'unpack 'setenv
>> + (lambda _
>> + (setenv "CC" (which "gcc"))))
>> + (add-after 'unpack 'patch-keynav
>> + (lambda _
>> + (substitute* "keynav.c"
>> + (("xdo_symbol_map") "xdo_get_symbol_map")
>> + (("xdo_window_setclass") "xdo_set_window_class")
>> + (("xdo_window_get_active") "xdo_get_window_at_mouse")
>> + (("xdo_click") "xdo_click_window")
>> + (("xdo_mouseup") "xdo_mouse_up")
>> + (("xdo_mousedown") "xdo_mouse_down")
>> + (("xdo_mousemove") "xdo_move_mouse")
>> + (("xdo_mousemove_relative") "xdo_move_mouse_relative")
>> + (("xdo_mouselocation") "xdo_get_mouse_location")
>> + (("xdo_mouse_wait_for_move_to") "xdo_wait_for_mouse_move_to")
>> + (("xdo_keysequence_up") "xdo_send_keysequence_window_up")
>> + (("xdo_keysequence_down")
>> "xdo_send_keysequence_window_down"))))
>> + (delete 'configure)
>> + (replace 'install
>> + (lambda* (#:key outputs #:allow-other-keys)
>> + (let ((out (assoc-ref outputs "out")))
>> + (install-file "keynav" (string-append out "/bin"))
>> + (install-file "keynavrc" (string-append out "/etc"))))))))
>
> Please return #t in each of these phases.
OK, pushed as with a6a2ef27a389f5ff88b752ba56a7f34d94cb087b with:
diff --git a/gnu/packages/xorg.scm b/gnu/packages/xorg.scm
index 864ebb0a4..4bad8f23f 100644
--- a/gnu/packages/xorg.scm
+++ b/gnu/packages/xorg.scm
@@ -6147,12 +6147,13 @@ and embedded platforms.")
(native-inputs
`(("pkg-config" ,pkg-config)))
(arguments
- `(#:tests? #f
+ `(#:tests? #f ;No tests.
#:phases
(modify-phases %standard-phases
(add-after 'unpack 'setenv
(lambda _
- (setenv "CC" (which "gcc"))))
+ (setenv "CC" (which "gcc"))
+ #t))
(add-after 'unpack 'patch-keynav
(lambda _
(substitute* "keynav.c"
@@ -6167,13 +6168,15 @@ and embedded platforms.")
(("xdo_mouselocation") "xdo_get_mouse_location")
(("xdo_mouse_wait_for_move_to") "xdo_wait_for_mouse_move_to")
(("xdo_keysequence_up") "xdo_send_keysequence_window_up")
- (("xdo_keysequence_down") "xdo_send_keysequence_window_down"))))
+ (("xdo_keysequence_down") "xdo_send_keysequence_window_down"))
+ #t))
(delete 'configure)
(replace 'install
(lambda* (#:key outputs #:allow-other-keys)
(let ((out (assoc-ref outputs "out")))
(install-file "keynav" (string-append out "/bin"))
- (install-file "keynavrc" (string-append out "/etc"))))))))
+ (install-file "keynavrc" (string-append out "/etc")))
+ #t)))))
(home-page "https://www.semicomplete.com/projects/keynav/")
(synopsis "Keyboard-driven mouse cursor mover")
(description
Oleg.
signature.asc
Description: PGP signature