[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#32046] [PATCH] import: gem: Add recursive import.
From: |
Oleg Pykhalov |
Subject: |
[bug#32046] [PATCH] import: gem: Add recursive import. |
Date: |
Tue, 10 Jul 2018 16:31:59 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Hello Ludovic,
Thank you for review.
address@hidden (Ludovic Courtès) writes:
> Hi Oleg,
>
> Oleg Pykhalov <address@hidden> skribis:
>
>> * doc/guix.texi (Invoking guix import): Document gem recursive import.
>> * guix/import/gem.scm (gem->guix-package): Return package and dependencies
>> values.
>> (gem-recursive-import): New procedure.
>> * guix/scripts/import/gem.scm (show-help, %options): Add recursive option.
>> (guix-import-gem): Use 'gem-recursive-import'.
>
> Nice!
>
> Could you add a test in tests/gem.scm?
>
>> (define-module (guix import gem)
>> #:use-module (ice-9 match)
>> #:use-module (ice-9 pretty-print)
>> + #:use-module (ice-9 receive)
>
> I don’t think this is needed.
>
>> @@ -44,6 +46,8 @@ Import and convert the RubyGems package for
>> PACKAGE-NAME.\n"))
>> -h, --help display this help and exit"))
>> (display (G_ "
>> -V, --version display version information and exit"))
>> + (display (G_ "
>> + -r, --recursive generate package expressions for all Gem packages
>> that are not yet in Guix"))
>
> Please keep lines below 80-char wide.
>
> Apart form that LGTM. Could you send an updated patch?
I applied all your suggestions. Here is a new patch.
<#secure method=pgpmime mode=sign>
0001-import-gem-Add-recursive-import.patch
Description: [PATCH] import: gem: Add recursive import.
signature.asc
Description: PGP signature