[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#32813] [PATCH 1/4] gnu: Add tegola.
From: |
Björn Höfling |
Subject: |
[bug#32813] [PATCH 1/4] gnu: Add tegola. |
Date: |
Tue, 25 Sep 2018 19:04:59 +0200 |
On Sun, 23 Sep 2018 22:43:08 +0200
Julien Lepiller <address@hidden> wrote:
> * gnu/packages/geo.scm (tegola): New variable.
> ---
> gnu/packages/geo.scm | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/gnu/packages/geo.scm b/gnu/packages/geo.scm
> index ae6ba024e..e6aafff7d 100644
> --- a/gnu/packages/geo.scm
> +++ b/gnu/packages/geo.scm
> @@ -760,3 +760,33 @@ location queries to be run in SQL.")
> license:bsd-3 ; files only say "BSD"
> ;; doc
> license:cc-by-sa3.0))))
> +
> +(define-public tegola
> + (package
> + (name "tegola")
> + (version "0.7.0")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append
> + "https://github.com/go-spatial/tegola/archive/v"
> + version ".tar.gz"))
> + (sha256
> + (base32
> +
> "09vnzxfn0r70kmd776kcdfqxhzdj11syxa0b27z4ci1k367v7viw"))))
> + (build-system go-build-system)
> + (arguments
> + `(#:import-path "github.com/go-spatial/tegola/cmd/tegola"
> + #:unpack-path "github.com/go-spatial"
> + #:phases
> + (modify-phases %standard-phases
> + (add-before 'build 'rename-import
> + (lambda _
> + (rename-file (string-append
> "src/github.com/go-spatial/tegola-" ,version)
> + "src/github.com/go-spatial/tegola")
> + #t)))))
> + (home-page "http://tegola.io")
> + (synopsis "Vector tile server for maps")
> + (description "Tegola is a free vector tile server written in
> Go. Tegola +takes geospatial data and slices it into vector tiles
> that can be efficiently +delivered to any client.")
> + (license license:expat)))
Hi Julien,
thanks for the patch-set!
Here are my remarks:
Import for go-system missing:
+ #:use-module (guix build-system go)
./pre-inst-env guix lint $REVIEW_PACKAGE
gnu/packages/geo.scm:770:12: address@hidden: the source file name should
contain the package name
--> i.e. add to the source a line:
(file-name (string-append name "-" version ".zip"))
Under directory 'vendor' are a bunch of dependencies. I never used Go,
so I ask carefully:
* Do we already have them as a package (or some of them)?
* Can those be snipped away?
* If not, please check the licenses. With licensecheck, I found at
least:
Apache 2.0
BSD-2
BSD-3
And here is one I didn't know yet and I think we don't yet have a
license term for it in Guix :-)
vendor/github.com/BurntSushi/toml/COPYING
DO WHAT THE FUCK YOU WANT TO PUBLIC LICENSE
Isn't that nice? :-)
I ran the program and got:
./pre-inst-env guix environment --ad-hoc tegola -- tegola version
version not set
But I wouldn't invest too much time into this one, as long as the
"serve" command works (havn't tried that).
Thanks,
Björn
pgproJb0xXuV0.pgp
Description: OpenPGP digital signature