guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#33134] [PATCH 2/5] guix-install.sh: Add parse_args.


From: Danny Milosavljevic
Subject: [bug#33134] [PATCH 2/5] guix-install.sh: Add parse_args.
Date: Tue, 6 Nov 2018 12:27:52 +0100

Hi,

> +    # process -y / -n arg.
> +    export AUTO_YN=${1:1:1}
> +    if [ -z $AUTO_YN ]; then
> +        export AUTO_YN=""
> +    fi

Why "export" ? Now all the child processes get it, making their environment
different from before.  This makes parse_args have system-wide side effects.

If we wanted to export it, we could do it explicitly after parse_args has
been called.

Attachment: pgptHyM9nf5jp.pgp
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]