[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#33334] [PATCH]:gnu:add ne:the nice editor

From: swedebugia
Subject: [bug#33334] [PATCH]:gnu:add ne:the nice editor
Date: Sat, 10 Nov 2018 22:20:41 +0100

Hi :)
Did you run ./pre-inst-env guix lint on the package?
It has trailing whitespaces in two places.

On 2018-11-10 10:25, guy fleury wrote:
hi all,

i have packaged: ne "the nice editor".
it is my first tempt to contribute to any project,if i do things wrong
tell me with additionnal informations!

Thank you! Me too. I submitted my first patch ever to Guix a few days ago. :)


 From 1ec45eaa225e7203a98b36cddb7d42db418b773b Mon Sep 17 00:00:00 2001
From: guy fleury<address@hidden>
Date: Sat, 10 Nov 2018 10:51:17 +0200
Subject: [PATCH] gnu:add ne:the nice editor


+    (build-system gnu-build-system)
+    (arguments
+       `(#:tests? #f

Could you please explain why the tests are disabled?
Search the packages to see examples of explanations.

+          #:make-flags (list (string-append "PREFIX=" (assoc-ref %outputs 
+                   "CC=gcc")
+         #:parallel-build? #f
+         #:phases (modify-phases %standard-phases
+                                 (delete 'configure))))

Same here. Please explain.

Tested the compilation and ran the editor. Seemed nice!

Maybe this could complement nano if it highlights scheme and has a macro to help with e.g. finding missing parens.

Could you send an updated patch?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]