[bug#33334] [PATCH]:gnu:add ne:the nice editor

[guy fleury]

Le samedi 10 novembre 2018 à 22:20 +0100, swedebugia a écrit :
> Hi :)
> Did you run ./pre-inst-env guix lint on the package?
> It has trailing whitespaces in two places.
------------------------------------------------------
./pre-inst-env guix lint ne
gnu/packages/nano.scm:85:7: address@hidden: sentences in description should
be followed by two spaces; possible infraction at 78
accepted connection from pid 16902, user guy
gnu/packages/nano.scm:83:14: address@hidden: synopsis should start with an
upper-case letter or digit
gnu/packages/nano.scm:83:14: address@hidden: synopsis should not start with
the package name
guix lint: warning: while retrieving CVE vulnerabilities: TLS
certificate error: X.509 certificate of 'nvd.nist.gov' could not be
verified:
  signer-not-found
  invalid

gnu/packages/nano.scm:56:2: address@hidden: trailing white space on line 80
gnu/packages/nano.scm:56:2: address@hidden: trailing white space on line 85
gnu/packages/nano.scm:56:2: address@hidden: trailing white space on line 86
gnu/packages/nano.scm:56:2: address@hidden: trailing white space on line 87
-----------------------------------------------------------------------
i failed to indent well.Perphaps you can do it.it compiles quickly.
yes i know,i got soon learn to indent.
> On 2018-11-10 10:25, guy fleury wrote:
> > hi all,
> > 
> > i have packaged: ne "the nice editor".
> > it is my first tempt to contribute to any project,if i do things
> > wrong
> > tell me with additionnal informations!
> 
> Thank you! Me too. I submitted my first patch ever to Guix a few
> days 
> ago. :)
> 
> > 0001-gnu-add-ne-the-nice-editor.patch
> > 
> >  From 1ec45eaa225e7203a98b36cddb7d42db418b773b Mon Sep 17 00:00:00
> > 2001
> > From: guy fleury<address@hidden>
> > Date: Sat, 10 Nov 2018 10:51:17 +0200
> > Subject: [PATCH] gnu:add ne:the nice editor
> 
> snip
> 
> > +    (build-system gnu-build-system)
> > +    (arguments
> > +       `(#:tests? #f
> 
> Could you please explain why the tests are disabled?
> Search the packages to see examples of explanations.
> 
> > +          #:make-flags (list (string-append "PREFIX=" (assoc-ref
> > %outputs "out"))
> > +                   "CC=gcc")
> > +         #:parallel-build? #f
> > +         #:phases (modify-phases %standard-phases
> > +                                 (delete 'configure))))
> 
> Same here. Please explain.
> 
> Tested the compilation and ran the editor. Seemed nice!
> 
> Maybe this could complement nano if it highlights scheme and has a
> macro 
> to help with e.g. finding missing parens.
i did that.
it not supports highlights scheme but show missing parens.
it supports also highlights in other languages(such c,c++,etc)
> Could you send an updated patch?

yes,here is my patch updated.

0001-gnu-Add-ne-A-nice-editor.patch
Description: Text Data