[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#33448] [PATCH 2/3] describe: Add json format.
From: |
Oleg Pykhalov |
Subject: |
[bug#33448] [PATCH 2/3] describe: Add json format. |
Date: |
Thu, 22 Nov 2018 15:54:44 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Hi Ludovic,
Almost done with current patch series and only one question.
address@hidden (Ludovic Courtès) writes:
> Oleg Pykhalov <address@hidden> skribis:
>
>> * guix/channels.scm (channel->json): New procedure.
>> * guix/scripts/describe.scm (%options): Add 'json' option.
>> (display-checkout-info, display-profile-info): Use 'channel->json'.
>> * doc/guix.texi (Invoking guix describe): Document this.
>
> [...]
>
>> +(define channel->json
>> + (match-lambda
>> + (($ <channel> name url branch commit location)
>> + (scm->json-string
>> + (list
>> + (cons 'name name)
>> + (cons 'url url)
>> + (cons 'commit commit))))))
>
> Since this is not a core feature of channels and add a dependency on
> (json), what about moving this procedure to (guix scripts describe)?
<channel> should be exported in (guix channels) in this case. Is it OK?
[…]
Oleg.
signature.asc
Description: PGP signature
[bug#33448] [PATCH 3/3] describe: Add recutils format., Oleg Pykhalov, 2018/11/21
[bug#33448] [PATCH 1/3] describe: Use a procedure to format output., Ludovic Courtès, 2018/11/21