[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#33893] [PATCH v5 2/4] gnu: Add docker-engine.
From: |
Ludovic Courtès |
Subject: |
[bug#33893] [PATCH v5 2/4] gnu: Add docker-engine. |
Date: |
Sun, 06 Jan 2019 21:20:35 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Danny Milosavljevic <address@hidden> skribis:
> * gnu/packages/docker.scm (docker-engine): New variable.
> (%docker-version): New variable.
[...]
> + ;(("LookPath") "Guix_doesnt_want_LookPath")
No longer needed?
> + (replace 'configure
> + (lambda _
> + (setenv "DOCKER_GITCOMMIT" (string-append "v" ,%docker-version))
> + (setenv "AUTO_GOPATH" "1")
Could you add a comment saying what AUTO_GOPATH does?
> + (replace 'build
> + (lambda _
> + ;(invoke "hack/make.sh" "binary")
> + ; FIXME: bash -c 'hack/validate/default && hack/make.sh'
It’s not clear to me what should be fixed; perhaps a leftover?
> + (replace 'check
> + (lambda _
> + ; FIXME: Those don't find any of the go packages
> + ; needed. Probably GOPATH/GOROOT related.
> + ;(invoke "hack/test/unit")
> + #t))
That’s potentially problematic. :-) Any idea how difficult it would be
to run these tests?
> + (replace 'install
> + (lambda* (#:key outputs #:allow-other-keys)
> + (let* ((out (assoc-ref outputs "out"))
> + (out-bin (string-append out "/bin")))
> + (install-file "bundles/dynbinary-daemon/dockerd" out-bin)
> + (install-file "bundles/dynbinary-daemon/dockerd-dev" out-bin))
> + ;(setenv "DOCKER_MAKE_INSTALL_PREFIX" (assoc-ref outputs "out"))
> + ; TODO: KEEPBUNDLE=1
> + ;./source/bundles/dynbinary-daemon/dockerd
> + ;(invoke "hack/make.sh" "install-binary")
Comments can be removed?
Otherwise LGTM, thanks!
Ludo’.
- [bug#33893] [PATCH v5 2/4] gnu: Add docker-engine.,
Ludovic Courtès <=