[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#33976] [PATCH] gnu: Add dev86.
From: |
Ludovic Courtès |
Subject: |
[bug#33976] [PATCH] gnu: Add dev86. |
Date: |
Wed, 09 Jan 2019 17:21:59 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Hi,
Danny Milosavljevic <address@hidden> skribis:
> * gnu/packages/assembly.scm (dev86): New variable.
[...]
> + (arguments
> + `(#:make-flags (list "-j" "1" ; They use submakes wrong
Maybe #:parallel-build? #f for clarity.
> + #:system "i686-linux" ; Standalone ld86 had problems otherwise
Please add ‘supported-systems’ accordingly.
> + #:tests? #f ; No tests exist
> + #:phases
> + (modify-phases %standard-phases
> + (delete 'configure)
> + (add-before 'install 'mkdir
> + (lambda* (#:key outputs #:allow-other-keys)
> + (let ((out (assoc-ref outputs "out")))
> + (mkdir-p (string-append out "/bin"))
> + (mkdir-p (string-append out "/man/man1"))
> + #t))))))
> + (synopsis "X86 16-bit assembler, C compiler and linker")
> + (description "This package provides a X86 16-bit assembler, a C compiler
> +and a linker.")
s/X86/Intel 8086/, no?
It’d be nice to add a few words about what’s special about this
toolchain (not obvious from their README…).
> + (home-page "https://github.com/jbruchon/dev86")
> + (license license:gpl2)))
There are no headers in source files so it should be gpl2+.
OK with these changes, thank you!
Ludo’.