guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#33980] gnu: Add pwsafe


From: Tim Gesthuizen
Subject: [bug#33980] gnu: Add pwsafe
Date: Wed, 9 Jan 2019 22:27:25 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0

Hi Ludo,

>> +    ;; TODO: The help subsystem cannot be initialized
>> +    ;; TODO: pwsafe tries to download GTest which does not work in the 
>> daemon
>> +    ;; environment and is not functional. Substitute CMakeLists.txt to use
>> +    ;; native GTest and reenable unit tests.
>> +    (arguments '(#:configure-flags (list "-DNO_GTEST=YES")))
> 
> It would be ideal if you could get the tests running.  :-)

Done. It's a really ugly hack but they are running.
This uncovered the problem of the help system not initializing because
/usr/bin/file was hardcoded. So enabling unit tests was a good idea (as
always) :)


>> +    (native-inputs `(("coreutils" ,coreutils)
> 
> Coreutils is not needed, it’s an implicit input already.

Removed.

>> +    (synopsis "Password safe to store passwords encrypted")
>> +    (description "A password manager originally designed by Bruce Schneier.
>> +It offers a simple UI to manage passwords for different services.  There are
>> +other programs that support the file format on different plattforms.")
>                                                                ^^
> Typo.
> 
> Also please make full sentences.

Hope I got everything corrrect this time.
Patch is attached.

Tim.

Attachment: 0001-gnu-Add-pwsafe.patch
Description: Text Data

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]