guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#34086] [PATCH] Add StepMania


From: Ludovic Courtès
Subject: [bug#34086] [PATCH] Add StepMania
Date: Wed, 23 Jan 2019 10:40:31 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)

Hi Nicolas,

Nicolas Goaziou <address@hidden> skribis:

> From 00196d57d6987ed4e93d5cd51af3a4c2d20cc7f3 Mon Sep 17 00:00:00 2001
> From: Nicolas Goaziou <address@hidden>
> Date: Sun, 11 Nov 2018 00:43:34 +0100
> Subject: [PATCH] gnu: Add stepmania.
>
> * gnu/packages/games.scm (stepmania):
> * gnu/packages/video.scm (ffmpeg-for-stepmania): New variables.

[...]

> +(define-public ffmpeg-for-stepmania
> +  (hidden-package
> +   (inherit ffmpeg)
> +   (version "2.1.3")

I’m pretty sure this doesn’t evaluate, does it?  :-)

Should be:

  (hidden-package
    (package
      (inherit ffmpeg)
      …))

Apart from that, could you please add the explanation and/or a link to
an upstream discussion summarizing what you described regarding this
choice of a custom FFMpeg variant?

OK with this changes!

Thanks,
Ludo’.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]