[bug#34265] [PATCH 2/9] gnu: sexplib0: Update to 0.12-preview.120.18+252.

[Julien Lepiller]

Le 31 janvier 2019 17:20:24 GMT+01:00, Gabriel Hondet <address@hidden> a écrit :
>
>* gnu/packages/ocaml.scm (sexplib0): Update to 0.12-preview.120.18+252.
>---
> gnu/packages/ocaml.scm | 20 +++++++++++++++-----
> 1 file changed, 15 insertions(+), 5 deletions(-)
>
>diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm
>index 986e435f4..5f95591d9 100644
>--- a/gnu/packages/ocaml.scm
>+++ b/gnu/packages/ocaml.scm
>@@ -4903,27 +4903,37 @@ exclusion algorithms are typical examples of
>such systems.")
> (define-public ocaml-sexplib0
>   (package
>     (name "ocaml-sexplib0")
>-    (version "0.11.0")
>+    (version "0.12-preview.120.18+252")
>     (home-page "https://github.com/janestreet/sexplib0";)
>     (source
>      (origin
>        (method git-fetch)
>        (uri (git-reference
>              (url (string-append home-page ".git"))
>-             (commit (string-append "v" version))))
>+             (commit "7e602a00a9b7c037f3717cc60577a2aad8941830")))
>        (file-name (git-file-name name version))
>        (sha256
>         (base32
>-         "07v3ggyss7xhfv14bjk1n87sr42iqwj4cgjiv2lcdfkqk49i2bmi"))))
>+         "0hrxy52nbnrd9l9v66klghsdy7xnbsjk85fb1rdkhcjcr38jnmad"))))
>     (build-system dune-build-system)
>     (arguments
>-     '(#:tests? #f)) ;no tests
>+     '(#:tests? #f ;no tests
>+       #:phases
>+       (modify-phases %standard-phases
>+         (replace 'install
>+           (lambda* (#:key outputs #:allow-other-keys)
>+             (invoke "dune" "install"
>+                     (string-append "--libdir="
>+                                    (assoc-ref outputs "out")
>+                                    "/lib/ocaml/site-lib")
>+                     (string-append "--prefix="
>+                                    (assoc-ref outputs "out"))))))))
> (synopsis "Library containing the definition of S-expressions and some
> base converters")
>     (description "Part of Jane Street's Core library The Core suite of
>libraries is an industrial strength alternative to OCaml's standard
>library
>that was developed by Jane Street, the largest industrial user of
>OCaml.")
>-(license license:expat)))
>+    (license license:expat)))
> 
> (define-public ocaml-parsexp
>   (package

Hi Gabriel, thanks for these patches!

We usually don't use beta,preview or otherwise unreleased software in guix. The 
opam website still has 0.11.0 as the latest version. What's the reason behind 
this change?

Tge libdir thing is worrying. Is it now needed with newer versions of dune? 
Shouldn't we rather modify the dure-build-system?

These questions apply to other packages in the series, so I'll refrain from 
pushing anything for now.