[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#34497] Add odamex
From: |
Ricardo Wurmus |
Subject: |
[bug#34497] Add odamex |
Date: |
Wed, 20 Feb 2019 21:47:00 +0100 |
User-agent: |
mu4e 1.0; emacs 26.1 |
Hi pkill9,
> * gnu/packages/games.scm (odamex): New variable.
[…]
> + (uri (string-append
> + "mirror://sourceforge/odamex/Odamex/"
> + version
> + "/odamex-src-"
> + version
> + ".tar.gz"))
Please put this on fewer lines.
> + (sha256
> + (base32
> + "1sh6lqj7vsdmnqz17hw0b6vy7xx6dp41k2sdw99ympsfa2xd1d2j"))))
> + (build-system cmake-build-system)
> + (arguments `(#:tests? #f)) ;; No tests
Please use just one semicolon.
> + (inputs
> + `(("sdl" ,(@ (gnu packages sdl) sdl))
> + ("sdl-mixer" ,(@ (gnu packages sdl) sdl-mixer))
> + ("zlib" ,(@ (gnu packages compression) zlib))
> + ("libpng" ,(@ (gnu packages image) libpng))
> + ("alsa-lib" ,(@ (gnu packages linux) alsa-lib))))
This is not okay. Please just use the plain variable names.
> + (home-page "https://odamex.net/")
> + (synopsis "Multiplayer Doom port")
> + (description "Odamex is a free, cross-platform modification of the Doom
> +engine that allows players to easily join servers dedicated to playing Doom
> +online.")
Please remove “free” — all software in Guix is Free Software.
> + (license license:gpl2)))
Looks like this is actually gpl2+ as evidenced by files like this:
https://github.com/odamex/odamex/blob/master/server/src/d_netinfo.cpp#L12
Could you please send an updated patch?
--
Ricardo