[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#34650] Acknowledgement ([PATCH] ruby-mailcatcher: Draft)
From: |
Pierre Neidhardt |
Subject: |
[bug#34650] Acknowledgement ([PATCH] ruby-mailcatcher: Draft) |
Date: |
Tue, 26 Feb 2019 11:59:27 +0100 |
User-agent: |
mu4e 1.0; emacs 26.1 |
Hi Christopher,
Thanks for all the details, that will help tremendously for sure.
> ruby-tilt
I tried applying your patch but I get the following error:
--8<---------------cut here---------------start------------->8---
starting phase `check'
rake aborted!
Bundler::VersionConflict: Bundler could not find compatible versions for gem
"ffi":
In Gemfile:
sassc was resolved to 2.0.0, which depends on
ffi (~> 1.9.6)
Could not find gem 'ffi (~> 1.9.6)', which is required by gem 'sassc', in any
of the sources.
--8<---------------cut here---------------end--------------->8---
I suppose that ruby-ffi was updated recently and that the version number needs
patching?
> I think theres a commit on the staging branch to pass the --verbose flag
> to gem install, which may be revealing.
I'll look into it, thanks for the tip.
> In my opinion, if you think someone might use it as a Ruby library,
> stick with the ruby- prefix for consistency. Otherwise, call it what you
> think makes most sense.
I'll call if mailcatcher then.
> If you're confident that the more recent versions of the dependencies
> work, then I'd recommend patching the source to loosen the dependency
> constraints.
I see that's what you are doing in your patch. It's quite cumbersome though :p
At this point I wonder: if the developer explicitly say
"A should be version X or above, while B should be exactly version Y", shouldn't
we respect the upstream wish?
--
Pierre Neidhardt
https://ambrevar.xyz/
signature.asc
Description: PGP signature
- [bug#34650] [PATCH] ruby-mailcatcher: Draft, Pierre Neidhardt, 2019/02/25
- Message not available
- [bug#34650] Acknowledgement ([PATCH] ruby-mailcatcher: Draft), Pierre Neidhardt, 2019/02/25
- [bug#34650] Acknowledgement ([PATCH] ruby-mailcatcher: Draft), Christopher Baines, 2019/02/25
- [bug#34650] Acknowledgement ([PATCH] ruby-mailcatcher: Draft),
Pierre Neidhardt <=
- [bug#34650] [PATCH 1/7] gnu: ruby-rack-protection: Update to 2.0.5., Pierre Neidhardt, 2019/02/28
- [bug#34650] [PATCH 7/7] gnu: Add mailcatcher., Pierre Neidhardt, 2019/02/28
- [bug#34650] [PATCH 2/7] gnu: Add ruby-tilt., Pierre Neidhardt, 2019/02/28
- [bug#34650] [PATCH 6/7] gnu: Add ruby-skinny., Pierre Neidhardt, 2019/02/28
- [bug#34650] [PATCH 4/7] gnu: Add ruby-sinatra., Pierre Neidhardt, 2019/02/28
- [bug#34650] [PATCH 3/7] gnu: Add ruby-mustermann., Pierre Neidhardt, 2019/02/28
- [bug#34650] [PATCH 5/7] gnu: Add ruby-thin., Pierre Neidhardt, 2019/02/28
- [bug#34650] Acknowledgement ([PATCH] ruby-mailcatcher: Draft), Pierre Neidhardt, 2019/02/28