Re: [Gzz-commits] journals mudyc tjl

[Tuomas Lukka]

> 
> > +   - you should start by documenting what it needs to do, then deriving
> > +     the interfaces from that
> 
> The self-explaining interface is:
> 
>     /** Two change methods:
>      * - change(float x, float y) for delta change.
>      * - controlPoint(float x, float y, float scale).
>      * The 'change' is aimed for adjusting zoom etc. 
>      * which needs change to some direction.
>      * On the other hand 'controlPoint' is for mouse cursor 
>      * point. With it can be mouse clicks handed.
>      *
>      * To ask from action which one of the two method is used
>      * the method 'isChangeable' is called.
>      */
>     public interface Controller {
>       boolean isChangeable();
>       
>       /** If controller action can be made without 
>        * creating a new VobScene this should return true.
>        */
>       boolean tryFast();
>         void change(float x, float y);
>         void controlPoint(float x, float y, float scale);
>       
>       /** When ControlBinding's 
>        * handleEvent is called the 'forObject' and 'oldVS' 
>        * are given with set method.
>        */
>         void set(Object obj, VobScene oldVS);
>     }
> 
> Hmm.. Controller is more like an action.

This is not self-explanatory. What is the difference between 
change and controlPoint.

And you should specify this interface carefully in the PEG.

Do we need different interfaces for different things: something 
where you zoom by mouse should go by different route from where
you can drag different objects.

> > +   - needs documentation
> 
> What needs documentation?

The whole controller thing - it's not at all obvious what all
the different pieces do.

> > +   - can it allow, e.g. several different drags based on what
> > +     object was clicked, i.e. who can route drags to the object
> > +     that was clicked and how?
> 
> see org/fenfire/view/buoy/actions.py:: 
> class ControlsDispatcher(ff.util.ControlBinding):

The comment for that, rather complicated class is

        ####### Dispatcher for plane events etc.

which doesn't really help.

I don't understand what it does and how.

> 
> 
> > -2003-08-01:
> > -    - [mudyc] in libvob/include/vob/jni/Types.hxx
> > -      how?
> > -      START_VOB_JNI_CONVERSION(float *, "float []", jfloatArray) 
> > -          out = env->GetFloatArrayElements(in, 0);
> > -      END_VOB_JNI_CONVERSION
> 
> This still doesn't work. Could you look for it?

Could you be *far* more specific: what have you changed, and what
are the symptoms now.

I think the most important thing is the controller PEG, 
do we need the float[] for something as urgently? We need to
finish FenPDF 1.0.

        Tuomas