[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Health-dev] More Trytonic style coding guidelines for GnuHealth
From: |
Luis Falcon |
Subject: |
Re: [Health-dev] More Trytonic style coding guidelines for GnuHealth |
Date: |
Wed, 1 Oct 2014 18:58:35 +0100 |
Hi Oscar
Thanks for your suggestions ! Let me try to answer.
On Sat, 27 Sep 2014 13:22:30 -0500
Oscar Alvarez <address@hidden> wrote:
> Hi Devs
>
> I would like to propose you to do little changes, for improvement
> coding design of some modules of Gnuhealth, the changes are:
>
>
> 1. Some Class has not to follow conventional order for the
> fields-methods, example HealthProfessional, because first defines a
> classmethod (get_health..) and next the fields, this for new
> developers is a little confuse.
>
OK.
> 2. I think that file health.py in main base module must be splitted
> in three files:
>
> - health.py (All modules except party and product related)
> - party.py (with PartyPatient and PartyAddress)
> - product.py (with Product, ProductCategory, ...)
>
> this let's understand/debug to better way this big and great module.
>
I would not do this now. I actually like having them on health.py . We
can discuss it in more detail with the community at the upcoming
TUL[1] and IRC channel.
> 3. The naming some view files doesn't follow tryton convention, for
> example: "gnuhealth_health_service.xml", must be
> "gnuhealth_health_service_form.xml", the last word "form" is missing,
> news developer has guess what kind of file is this xml.
>
OK
>
> I can to work around this changes, If you are agree ¿?,
OK for points 1 and 3 to include in upcoming 2.8
Also, we need to enforce PEP8 compliance. Some modules are better than
others in this respect.
1.- The Tryton Unconference Leipzig . http://tul2014.tryton.org/
Best,
>
> Thanks, I hope your opinions.
>
> Oscar Alvarez
>
>
>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Health-dev] More Trytonic style coding guidelines for GnuHealth,
Luis Falcon <=