[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
patch for missing 'chek' prior to edit
From: |
Mel Hatzis |
Subject: |
patch for missing 'chek' prior to edit |
Date: |
Sat, 08 Mar 2003 20:37:22 -0800 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20021130 |
Please review the following patch which fixes a bug whereby
a 'chek' is not performed when submitting an edited PR.
I noticed that 'chek initial' is done for submitnewpr but
there's no 'chek' for submitedit. This means that field
validation based on the the field definitions in the dbconfig
is not performed for PR edits.
Here's the patch...
Index: gnatsweb.pl
===================================================================
RCS file: /cvsroot/gnatsweb/gnatsweb/gnatsweb.pl,v
retrieving revision 1.120
diff -u -p -r1.120 gnatsweb.pl
--- gnatsweb.pl 8 Jan 2003 13:04:17 -0000 1.120
+++ gnatsweb.pl 9 Mar 2003 04:37:01 -0000
@@ -1808,6 +1808,10 @@ sub submitedit
# Submit the edits. We need to unlock the PR even if the edit fails
local($suppress_client_exit) = 1;
+ client_cmd("chek");
+ last LOCKED if ($client_would_have_exited);
+ client_cmd("$newpr\n.");
+ last LOCKED if ($client_would_have_exited);
client_cmd("editaddr $db_prefs{'user'}");
last LOCKED if ($client_would_have_exited);
client_cmd("edit $pr");
--
Mel Hatzis
- patch for missing 'chek' prior to edit,
Mel Hatzis <=