Re: pcl-cvs: suppress empty dirs?

[Jérôme]

It is quite straightforward to patch pcvs-parse.el to have the Emacs 21
behavior.
See patch below.
Maybe it would be good to add an option to let people choose the
behavior they want.
I will try to suggest this to the maintainer of this package


*** c:/emacs-22/lisp/pcvs-parse.el      Tue May 30 12:15:49 2006
--- c:/emacs-22/lisp/pcvs-parse.el.orig Mon May 01 13:43:48 2006
***************
*** 265,285 ****
         ;; [-n update] A new (or pruned) directory appeared but isn't
traversed
         (and
        (cvs-match "New directory `\\(.*\\)' -- ignored$" (dir 1))
!       (cvs-parsed-fileinfo 'MESSAGE " " (file-name-as-directory dir)))
        ;; These messages either correspond to a true new directory
        ;; that an update will bring in, or to a directory that's empty
        ;; on the current branch (either because it only exists in other
        ;; branches, or because it's been removed).
! ;;    (if (ignore-errors
! ;;          (with-temp-buffer
! ;;            (insert-file-contents (expand-file-name
! ;;                                   ".cvsignore" (file-name-directory dir)))
! ;;            (goto-char (point-min))
! ;;            (re-search-forward
! ;;             (concat "^" (regexp-quote (file-name-nondirectory dir)) "/$")
! ;;             nil t)))
! ;;        t                  ;The user requested to ignore those messages.
! ;;      (cvs-parsed-fileinfo '(NEED-UPDATE . NEW-DIR) dir t)))

         ;; File removed, since it is removed (by third party) in
repository.
         (and
--- 265,285 ----
         ;; [-n update] A new (or pruned) directory appeared but isn't
traversed
         (and
        (cvs-match "New directory `\\(.*\\)' -- ignored$" (dir 1))
!       ;; (cvs-parsed-fileinfo 'MESSAGE " " (file-name-as-directory dir))
        ;; These messages either correspond to a true new directory
        ;; that an update will bring in, or to a directory that's empty
        ;; on the current branch (either because it only exists in other
        ;; branches, or because it's been removed).
!       (if (ignore-errors
!             (with-temp-buffer
!               (insert-file-contents (expand-file-name
!                                      ".cvsignore" (file-name-directory dir)))
!               (goto-char (point-min))
!               (re-search-forward
!                (concat "^" (regexp-quote (file-name-nondirectory dir)) "/$")
!                nil t)))
!           t                  ;The user requested to ignore those messages.
!         (cvs-parsed-fileinfo '(NEED-UPDATE . NEW-DIR) dir t)))

         ;; File removed, since it is removed (by third party) in
repository.
         (and

Steinar Bang a écrit :

>
> I agree.  If this is the default behaviour of the next Emacs, I will
> have to see if I can get an older pcl-cvs to run, overriding the one
> distributed with emacs.
> 
> Which would be both a hazzle and a pity, from my POV.